Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issues with absolute paths #2063

Merged
merged 7 commits into from
Jun 29, 2022
Merged

fix issues with absolute paths #2063

merged 7 commits into from
Jun 29, 2022

Conversation

davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented Jun 19, 2022

🤔 What's changed?

Line-level filtering now works when you provide a feature path as absolute, e.g.

cucumber-js /home/jan/project/features/example.feature:2

Since Gherkin is always providing a pickle.uri as relative to the working directory, we also match this on the cucumber side with PickleLineFilter.

⚡️ What's your motivation?

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@coveralls
Copy link

coveralls commented Jun 19, 2022

Coverage Status

Coverage increased (+0.002%) to 98.299% when pulling ed230cf on fix/absolute-paths-various into 1da05aa on main.

@davidjgoss davidjgoss merged commit 140fc02 into main Jun 29, 2022
@davidjgoss davidjgoss deleted the fix/absolute-paths-various branch June 29, 2022 08:59
@jan-molak
Copy link
Member

Thanks @davidjgoss!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants